Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle archives and preferred content better #219

Open
wants to merge 4 commits into
base: rawhide
Choose a base branch
from
Open

Handle archives and preferred content better #219

wants to merge 4 commits into from

Conversation

matejak
Copy link
Contributor

@matejak matejak commented Oct 12, 2022

The addon lost the ability to pick files from supplied archives based on kickstart specifications.
This PR allows this, which allows the addon to

  • handle archives with e.g. multiple datastream files, and to
  • throw error when an expected file in the archive is missing.

This PR fixes RHEL8 and RHEL9 BZs

@matejak matejak added port-RHEL8 Port this PR to the rhel8-branch port-RHEL9 Port this PR to the rhel9-branch labels Oct 12, 2022
@matejak
Add capability to preselect content from archives
2b57f08 
Users can specify content path and tailoring path in kickstarts,
and the addon should be able to assure that those files are available,
and that they have precedence over other files.
@matejak
Handle changes in content identification
81c4c03 
The code is able to handle changes in the way how oscap identifies
content much more gracefully.
@matejak
Remove unused code
3801e4d 
The function is not referenced anywhere in the project
@matejak matejak marked this pull request as ready for review October 12, 2022 14:43
@jan-cerny jan-cerny changed the title Handle archives and preferred content better. Handle archives and preferred content better Oct 13, 2022
@jan-cerny
Copy link
Member

@matejak I find it difficult to review this PR.

  1. I need to reproduce the BZs to verify that the changes in this PR fix the BZs. However, I miss a kickstart that is used to reproduce this BZs. When I add the %addon org_fedora_oscap snippet from rhbz#2129008 to my kickstart, change the IPs, URLs and paths in that snippet for my local values and then start a RHEL 8.7 installation, I get "error when fetching content" in the OAA spoke in the bottom, which is probably fine, but I don't see the messages that are listed in the BZ in the /tmp/anaconda.log. I assume that I can similarly struggle to reproduce with RHEL 9.1. Therefore, please attach the kickstarts that you used to reproduce and test this BZ on both RHEL 8.7 and 9.1 to this PR. Also, please describe the steps that you performed when you tested your patch.

  2. This PR is against master branch which is on Fedora, but I don't know how to test Fedora as the linked BZs are on RHEL 8.7 and 9.1. When I try to download the patch file from this PR URL and apply it to current upstream rhel8-branch branch it doesn't apply, probably there are conflicts. I can try to resolve these locally but I don't know if this would be fine. How can I test that this PR fixes the linked RHEL BZs?

@matejak matejak mentioned this pull request Oct 13, 2022
Merged
@matejak
Dont use tailoring if it is not expected
8985540 
Take tailorings into account only if it is specified in the kickstart.
Compulsive usage of tailoring may be unwanted.
@scrutinizer-notifier
Copy link

The inspection completed: 6 updated code elements

@jan-cerny jan-cerny self-assigned this Oct 14, 2022
@jan-cerny
Copy link
Member

To clarify, this will be done after #220 will be discussed because it's a RHEL 8 variant of this PR.

@jan-cerny
Copy link
Member

@matejak The PR #220 has been merged so this PR is now unblocked and you can start working on it.

Also, can you answer the question above about testing on Fedora? What are the steps that you have taken when testing this on Fedora?

@matejak matejak removed port-RHEL8 Port this PR to the rhel8-branch port-RHEL9 Port this PR to the rhel9-branch labels Nov 10, 2022
@jan-cerny
Copy link
Member

@matejak I'm strongly disappointed by no response.

@jan-cerny
Copy link
Member

@matejak PING

@jan-cerny
Copy link
Member

@matejak ping

@jan-cerny jan-cerny removed their assignment Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny Awaiting requested review from jan-cerny

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejak @jan-cerny @scrutinizer-notifier